Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor ReplaceMessage api #5079

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

simlecode
Copy link
Collaborator

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@simlecode simlecode self-assigned this Jul 13, 2022
@simlecode simlecode requested a review from hunjixin July 13, 2022 08:19
@codecov-commenter
Copy link

Codecov Report

Merging #5079 (5f78439) into master (52c7ad2) will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #5079   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         597     597           
  Lines       65079   65079           
======================================
+ Hits        16566   16578   +12     
+ Misses      46349   46338   -11     
+ Partials     2164    2163    -1     

@hunjixin hunjixin merged commit 408b11d into master Jul 14, 2022
@hunjixin hunjixin deleted the refactor/replacemessage branch July 14, 2022 01:37
simlecode added a commit that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants