Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix generating version in the current directory #5972

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented May 19, 2023

关联的Issues (Related Issues)

fix #5940

改动 (Proposed Changes)

修复 init 的时候会在启动目录生成 version 文件
修复删除 version 启动失败

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #5972 (184e8bc) into master (df34a6e) will increase coverage by 0%.
The diff coverage is 40%.

❗ Current head 184e8bc differs from pull request most recent head 13f7526. Consider uploading reports for the commit 13f7526 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5972   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         657     657           
  Lines       79671   79669    -2     
======================================
+ Hits        19564   19569    +5     
+ Misses      57524   57516    -8     
- Partials     2583    2584    +1     

@hunjixin hunjixin merged commit 43e0713 into master May 19, 2023
@hunjixin hunjixin deleted the fix/init branch May 19, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus] change venus init logic / 修改venus启动逻辑
3 participants