Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Return content range data immediately #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hannahhoward
Copy link
Contributor

Goals

Still working on this but this would return the data needed to set a content-range header in the service worker needed for video. The only problem: big signature change to fetchContent. It now returns a promise which contains the information needed for content length AND the async iterable.

Done

  • car functions changes (still messing around with these)
  • Saturn.fetchContent

TO DO

  • Implement fetchContentWithFallback so that it ALSO returns the same signature (not easy - for now I've just compressed the call to fetchContent)
  • Implement fetchContentBuffer so that it returns a comparable signature
  • Get tests passing

For discussion

The complexity add to do this is non-trivial (especially with fetchContentWithFallback). Maybe there's a better solution? I'm not sure there is though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant