Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report retrieval result break-down #263

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 20, 2024

After fetching recent miner measurements, print a summary of what retrieval results seen and their frequency.

I hacked this together very quickly; the code & names may not be up to our standards. Let me know what parts to improve!

After fetching recent miner measurements, print a summary of what
retrieval results seen and their frequency.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber June 20, 2024 15:51
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm! In addition, to me, code quality of bin scripts isn't as important as service code, but still I think this is fine

@bajtos bajtos merged commit 33389d2 into main Jun 21, 2024
6 checks passed
@bajtos bajtos deleted the feat-retrieval-result-breakdown branch June 21, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants