feat: more validation during preprocessing #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bajtos
commented
Dec 7, 2023
bajtos
commented
- refactor: types for raw and parsed measurements
- feat: more validation in pre-process step
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
@juliangruber I would like to push validations from 'retrieval-stats.js' to 'preprocess.js'. I am seeking early feedback:
(Some of the existing tests are failing now; I am aware of that.) |
bajtos
commented
Dec 7, 2023
| this.duration = endAt - startAt | ||
| if (this.duration < 0) { | ||
| throw new Error('Invalid measurement: end_at is before start_at.') | ||
| } | ||
| } |
There was a problem hiding this comment.
TODO: check that endAt > firstByteAt
juliangruber
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.