Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code in filer/tests/spec/time-flags.spec.js to use "const"/"let" instead of "var" #692

Closed
Violet-XiaoWeiHuang opened this issue Jan 28, 2019 · 1 comment
Closed

Update code in filer/tests/spec/time-flags.spec.js to use "const"/"let" instead of "var" #692

Violet-XiaoWeiHuang opened this issue Jan 28, 2019 · 1 comment
Assignees
@Violet-XiaoWeiHuang

Comments

@Violet-XiaoWeiHuang
Copy link
Contributor

I will update variable declarations to use "const"/"let" instead of of "var" based of the issue.
@Violet-XiaoWeiHuang Violet-XiaoWeiHuang mentioned this issue Jan 29, 2019
Merged
humphd pushed a commit that referenced this issue Feb 1, 2019
@Violet-XiaoWeiHuang @humphd
Fix ssue #692: Update code in filer/tests/spec/time-flags.spec.js (#696)
05057c4 
* installed npm

* modified time-flags.spec.js

* Update code to use const/let instead of var

* update the variable type from let to const

* add Strict mode

* review fixed
@humphd
Copy link
Contributor

humphd commented Feb 1, 2019

This is merged now, closing.

@humphd humphd closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Violet-XiaoWeiHuang Violet-XiaoWeiHuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humphd @Violet-XiaoWeiHuang