Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #660: Updated the code to replace var with let, const in strict mode #694

Merged
merged 2 commits into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@yuansheng1989
Copy link
Contributor

yuansheng1989 commented Jan 29, 2019

  • "var" was replaced with "let" or"const"
  • "use strict" is added to the file
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...00408f3. Read the comment docs.

@OlenaVyshnevska

This comment has been minimized.

Copy link
Contributor

OlenaVyshnevska commented Jan 29, 2019

Hey, I think it might be better to use const instead of let for fs and contents variables cause we aren't changing their values


describe('fs.readlink', function() {
beforeEach(util.setup);
afterEach(util.cleanup);

it('should be a function', function() {
var fs = util.fs();
let fs = util.fs();

This comment has been minimized.

@OlenaVyshnevska

OlenaVyshnevska Jan 30, 2019

Contributor

You might want to change let to const as we aren't changing "fs" value

expect(fs.readlink).to.be.a('function');
});

it('should return an error if part of the parent destination path does not exist', function(done) {
var fs = util.fs();
let fs = util.fs();

This comment has been minimized.

@OlenaVyshnevska

OlenaVyshnevska Jan 30, 2019

Contributor

Same here

@humphd

humphd approved these changes Jan 31, 2019

Copy link
Contributor

humphd left a comment

Looks great

@humphd humphd merged commit e5481ef into filerjs:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.