Fix issue #660: Updated the code to replace var with let, const in strict mode #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuansheng1989
commented
Jan 29, 2019
yuansheng1989
commented
- "var" was replaced with "let" or"const"
- "use strict" is added to the file
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232Continue to review full report at Codecov.
|
|
Hey, I think it might be better to use const instead of let for fs and contents variables cause we aren't changing their values |
OlenaVyshnevska
suggested changes
Jan 30, 2019
tests/spec/fs.readlink.spec.js
Outdated
|
|
||
| describe('fs.readlink', function() { | ||
| beforeEach(util.setup); | ||
| afterEach(util.cleanup); | ||
|
|
||
| it('should be a function', function() { | ||
| var fs = util.fs(); | ||
| let fs = util.fs(); |
There was a problem hiding this comment.
You might want to change let to const as we aren't changing "fs" value
OlenaVyshnevska
suggested changes
Jan 30, 2019
tests/spec/fs.readlink.spec.js
Outdated
| expect(fs.readlink).to.be.a('function'); | ||
| }); | ||
|
|
||
| it('should return an error if part of the parent destination path does not exist', function(done) { | ||
| var fs = util.fs(); | ||
| let fs = util.fs(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.