Fix issue #681: Updated filer/tests/spec/filer.filesystem.spec.js

[woosle1234]

require lines use const instead of var
variable declaration in local scopes use let instead of var

[codecov-io]

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...aa70c90. Read the comment docs.

[codecov-io]

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Impacted Files	Coverage Δ
src/shell/environment.js	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...fdec4b1. Read the comment docs.

[ithompson4]

Hi, I think you are missing 'use strict' at the top of your file.

[woosle1234]

Hi, I think you are missing 'use strict' at the top of your file.

Added

[humphd]

This is coming along well. There are two main things we need to do to finish it.

1. I think you've gotten confused about what's required for tests with a bug. You've added tests/bugs/issue681.js, which isn't actually necessary in this case. Sometimes we do this (i.e., add a test for a particular bug), because we are fixing a problem, and want to add a test to make sure it doesn't get added back again. The tests in tests/bugs/* are all specific to old bugs we don't want to regress. I've left some comments for how to undo this.

2. You need to make some changes to use const in the final file. What you did is actually correct, but you can use const because those variables won't every change.

[woosle1234]

This is coming along well. There are two main things we need to do to finish it.

1. I think you've gotten confused about what's required for tests with a bug. You've added tests/bugs/issue681.js, which isn't actually necessary in this case. Sometimes we do this (i.e., add a test for a particular bug), because we are fixing a problem, and want to add a test to make sure it doesn't get added back again. The tests in tests/bugs/* are all specific to old bugs we don't want to regress. I've left some comments for how to undo this.
2. You need to make some changes to use const in the final file. What you did is actually correct, but you can use const because those variables won't every change.

Changes implemented in commit "issue 681 revision v2"

[humphd]

Great!