Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Issue 684: Replace var with const, let in filer/tests/spec/filer.buffer.spec.js #697
Replaced instances of var with const and let, depending on the variable being declared. Const was used for the requires, whose values should not change. Let was used for everything else, as the values were permutable and accessed only within the scope they were declared in.
@@ Coverage Diff @@ ## master #697 +/- ## ========================================== - Coverage 86.71% 86.63% -0.08% ========================================== Files 16 16 Lines 1746 1736 -10 ========================================== - Hits 1514 1504 -10 Misses 232 232
referenced this pull request
Jan 29, 2019
OnesQuared left a comment
No real objection to the changes, seems pretty good, const was used for global while let was used for local. Only thing I noticed that is irrelevant which was the line 51? I guess you added a extra line and moved the brackets down
humphd left a comment
This is looking really good. A few things we can do to finish it.
Let me know when you've fixed this and pushed your changes, and I'll re-review.