Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #658: Updated the code to use "let", "const" instead of var, added strict mode #704

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@OlenaVyshnevska
Copy link
Contributor

OlenaVyshnevska commented Jan 29, 2019

  • "var" was changed to "let" or"const"

  • added "use strict" directive

@OlenaVyshnevska OlenaVyshnevska changed the title code refactoring, added strict mode Fixes #658: Updated the code to use "let", "const" instead of var, added strict mode Jan 29, 2019

@ithompson4

This comment has been minimized.

Copy link
Contributor

ithompson4 commented Jan 29, 2019

Hello Olena, I noticed the Codecov Report is missing inside your pull request (other students have). I though GitHub generates the Codecov Report automatically after a new pull request.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Jan 30, 2019

@OlenaVyshnevska it looks like a hiccup with the CodeCov service, waiting on the Travis build to finish. It did, see https://travis-ci.org/filerjs/filer/jobs/486082478#L1805. And your coverage report was posted at https://codecov.io/github/filerjs/filer/commit/5f59fff6f1aa784dc537db0339fdde89fee7308e

All is well.

@SeanPrashad

This comment has been minimized.

Copy link
Contributor

SeanPrashad commented Jan 30, 2019

@humphd Just curious - is this a result of a hook blowing up somewhere or something else?

@OlenaVyshnevska

This comment has been minimized.

Copy link
Contributor Author

OlenaVyshnevska commented Jan 30, 2019

@humphd oh, ok then, thanks for the help!

@humphd

humphd approved these changes Jan 31, 2019

Copy link
Contributor

humphd left a comment

This is great.

@humphd humphd merged commit fc545ee into filerjs:master Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.