Fixes #658: Updated the code to use "let", "const" instead of var, added strict mode #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaVyshnevska
changed the title
|
Hello Olena, I noticed the Codecov Report is missing inside your pull request (other students have). I though GitHub generates the Codecov Report automatically after a new pull request. |
|
@OlenaVyshnevska it looks like a hiccup with the CodeCov service, waiting on the Travis build to finish. It did, see https://travis-ci.org/filerjs/filer/jobs/486082478#L1805. And your coverage report was posted at https://codecov.io/github/filerjs/filer/commit/5f59fff6f1aa784dc537db0339fdde89fee7308e All is well. |
|
@humphd Just curious - is this a result of a hook blowing up somewhere or something else? |
|
@humphd oh, ok then, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"var" was changed to "let" or"const"
added "use strict" directive