Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed Issue #703 #711

Merged
merged 6 commits into from Mar 5, 2019

Conversation

Projects
None yet
6 participants
@dcoull
Copy link
Contributor

dcoull commented Jan 30, 2019

Updated variable declarations in times.spec.js from var to let and const. All tests passed

dcoull added some commits Jan 30, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #711 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   86.71%   86.71%   +<.01%     
==========================================
  Files          16       16              
  Lines        1746     1739       -7     
==========================================
- Hits         1514     1508       -6     
+ Misses        232      231       -1
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) ⬇️
src/stats.js 100% <0%> (ø) ⬆️
src/fs-watcher.js 92.3% <0%> (ø) ⬆️
src/shell/environment.js 100% <0%> (ø) ⬆️
src/filesystem/implementation.js 83.86% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...4c56c33. Read the comment docs.

@AlvinValdez
Copy link
Contributor

AlvinValdez left a comment

You can add "use strict" at the top of your file.

@ndngo

This comment has been minimized.

Copy link
Contributor

ndngo commented Jan 30, 2019

Some variables that were declared with let could be declared with const but this is more stylistic preference. Nice job! 💯

@@ -1,15 +1,15 @@
var util = require('../lib/test-utils.js');
var expect = require('chai').expect;
const util = require('../lib/test-utils.js');

This comment has been minimized.

@ithompson4

ithompson4 Jan 30, 2019

Contributor

Add 'use strict'; at the top of your file to use strict mode.

@humphd
Copy link
Contributor

humphd left a comment

This is a good start. There are some things we can do to improve it:

  1. Please follow-up on the feedback from @ithompson4 re: use strict
  2. Let's revert the unrelated change to package-lock.json: use git checkout master package-lock.json to get the correct version in this PR.
  3. You can change all your let uses below to const when the variable doesn't change in the given scope--I think that's true of all of them. You can try replacing them all, and run the tests. It will flag any that are wrong.

Please make these changes and let me know when it's ready for re-review.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Feb 12, 2019

@dcoull how is this coming?

@dcoull

This comment has been minimized.

Copy link
Contributor Author

dcoull commented Mar 5, 2019

@dcoull how is this coming?

Changes made as requested

@humphd
Copy link
Contributor

humphd left a comment

This is looking very close @dcoull, just one more fix to make:

git checkout master package-lock.json
git commit -m "Revert changes to package-lock.json
git push origin master
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Mar 5, 2019

@dcoull this still didn't work, maybe we should try this together when we see each other tomorrow. Can you bring your laptop and we do it together?

@humphd

humphd approved these changes Mar 5, 2019

Copy link
Contributor

humphd left a comment

Wait, I'm wrong. You did it perfectly. Nice work!

@humphd humphd merged commit 94d5ff8 into filerjs:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.