Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors.spec.js #718

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@PrimeN
Copy link
Contributor

PrimeN commented Jan 30, 2019

Updating errors.spec.js to use const/let appropriately instead of var.

Update errors.spec.js
Updating errors.spec.js to use const/let appropriately instead of var.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...a1cddb6. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...7c9374d. Read the comment docs.

@humphd
Copy link
Contributor

humphd left a comment

This is looking good. I noticed a few things you can fix, and left some comments. Also note: for all the uses of let they could actually be const, but I only mentioned the first two.

Show resolved Hide resolved tests/spec/errors.spec.js Outdated
Show resolved Hide resolved tests/spec/errors.spec.js Outdated
Show resolved Hide resolved tests/spec/errors.spec.js Outdated
Update errors.spec.js
- Changed corrected 'using' to 'use'.
- Changed 'let' to 'const' becuase the're not being changed during the function scope.
@humphd

humphd approved these changes Feb 5, 2019

Copy link
Contributor

humphd left a comment

Nice, looks great.

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Feb 5, 2019

@PrimeN one tip: you're fixing issue #664, so in your PR you can mention it by saying Fixes #664 and then GitHub will auto-close your issue when the PR gets merged. Next time!

@humphd humphd merged commit 9d4b264 into filerjs:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.