Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 728: Updated 'filer/tests/spec/' to use 'const/let' instead of 'var' #730

merged 5 commits into from Feb 12, 2019


None yet
4 participants
Copy link

kwchan19 commented Jan 31, 2019

  • Added strict mode in 'filer/tests/spec/'
  • Changed 'var' variables to use 'const'

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
  Coverage   86.71%   86.71%           
  Files          16       16           
  Lines        1746     1746           
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...c72e3a2. Read the comment docs.


humphd approved these changes Feb 5, 2019

Copy link

humphd left a comment

Looks great.


This comment has been minimized.

Copy link

humphd commented Feb 5, 2019

@kwchan19 @FineHHDocumentation, I'm confused about this PR. @kwchan19 opens it, and then there are 6 commits from @FineHHDocumentation. What's going on?

@humphd humphd merged commit 9487e8e into filerjs:master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.