Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-685 fix: replaced "var" with "let" in fs.unlink.spec.js #733

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@PriyankaCodes99
Copy link
Contributor

PriyankaCodes99 commented Jan 31, 2019

Pull request for issue-685.

@PriyankaCodes99 PriyankaCodes99 changed the title issue-685 fix: replaced var with let" in issue-685 fix: replaced "var" with "let" in fs.unlink.spec.js Jan 31, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #733 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #733      +/-   ##
=========================================
- Coverage   86.71%   86.6%   -0.12%     
=========================================
  Files          16      16              
  Lines        1746    1739       -7     
=========================================
- Hits         1514    1506       -8     
- Misses        232     233       +1
Impacted Files Coverage Δ
src/filesystem/interface.js 93.29% <0%> (-0.39%) ⬇️
src/filesystem/implementation.js 83.68% <0%> (-0.05%) ⬇️
src/stats.js 100% <0%> (ø) ⬆️
src/fs-watcher.js 92.3% <0%> (ø) ⬆️
src/shell/environment.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...34e5580. Read the comment docs.

@humphd
Copy link
Contributor

humphd left a comment

This is looking good. Can you change all your uses of let fsPromises = util.fs().promises; and let fs = util.fs(); to use const instead of let? The variables don't change at all in their scope.

Once you do that, and push again, let me know and I'll re-review.

@humphd

humphd approved these changes Feb 8, 2019

@humphd humphd merged commit f4e0dce into filerjs:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.