Update fs.read.spec.js #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
requested changes
Feb 12, 2019
tests/spec/fs.read.spec.js
Outdated
| const fs = util.fs(); | ||
| const wbuffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); | ||
| const rbuffer = Buffer.alloc(wbuffer.length); | ||
| const _result = 0; |
There was a problem hiding this comment.
This needs to be let, since it gets changed in lines 52 and 55 below. This is why travis is failing the build:
/home/travis/build/filerjs/filer/tests/spec/fs.read.spec.js
52:11 error '_result' is constant no-const-assign
55:13 error '_result' is constant no-const-assign
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
======================================
Coverage 86.6% 86.6%
======================================
Files 16 16
Lines 1739 1739
======================================
Hits 1506 1506
Misses 233 233Continue to review full report at Codecov.
|
humphd
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated let to const where appropriate