add test for fs.open with wx flag for existing file

[cdrani]

Fixes #623

[humphd]

@cdrani thanks for this! I checked what node does, and I see it returns an EEXIST vs. ENOENT.

I think we're probably doing the wrong there here: https://github.com/filerjs/filer/blob/master/src/filesystem/implementation.js#L623, and should be using new Errors.EEXIST(...).

Do you want to change what we're doing in implementation and update this test?

[cdrani]

Sure, no problem. I assume I should run build-tests after making this change before running test?

[cdrani]

The test is failing, expecting 'EEXIST' to equal 'ENOENT'.

[humphd]

You can just run npm test and it will rebuild automatically. Did you change your test file to expect EEXIST after making that change to the implementation?

Also, can you push your changes up again and I'll review again, and help fix anything.

[cdrani]

Yes, I made all the changes. Did not notice that somehow that fs.open.spec was placed in readonly mode by vim. 😅 . Tests are passing, will push now.

[codecov-io]

Codecov Report

Merging #745 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   86.65%   86.71%   +0.05%     
==========================================
  Files          16       16              
  Lines        1739     1739              
==========================================
+ Hits         1507     1508       +1     
+ Misses        232      231       -1

Impacted Files	Coverage Δ
src/filesystem/implementation.js	83.86% <100%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914ba8b...2bf1aa7. Read the comment docs.

[cdrani]

Concerning this

No binary for FirefoxHeadless browser on your platform.
Please, set "FIREFOX_BIN" env variable.

I noticed that I have ChromeHeadless, but not FirefoxHeadless. How are these setup? Why do I have one binary and not the other?

[humphd]

@cdrani do you have Firefox installed on your machine? That should be enough to make this work.

At any rate, this looks great, nice work. I'm going to merge.

[humphd]

Excellent.

[cdrani]

Oh, I use the developer version. That might be the issue. Thanks for the help!