Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed a crash that would occur when opening file pickers and Files was running as admin #15386

Merged
merged 26 commits into from
May 17, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 12, 2024

Summary

Fixing a bug, but also contains performance improvements because of calling native API.

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Type Where If Tested
NetworkConnectionDialog the drives widget dropdown button
FileSaveDialog extraction of user settings
FileOpenDialog folder costomization Brwose button
^ selector of app background image Browse button
^ album image editor button
^ changing a specific folder on startup button
^ decompress archive (Extract here at least) button
^ adding a specific folder to open on startup button
^ adding a location for a library Browse button

Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
0x5bfa and others added 2 commits May 16, 2024 08:35
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
@0x5bfa
Copy link
Member Author

0x5bfa commented May 16, 2024

For application background and album background file picker, I’m working on improving filter UX. Should be addressed by today (UTC+9)

@yaira2
Copy link
Member

yaira2 commented May 16, 2024

I discovered an issue

  1. Open properties for mp3 file
  2. Click the edit photo button
  3. Select an image
  4. The app crashes

@0x5bfa
Copy link
Member Author

0x5bfa commented May 16, 2024

There was a invalid cast, fixed.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 17, 2024
@yaira2 yaira2 merged commit b5a7eac into files-community:main May 17, 2024
6 checks passed
@yaira2 yaira2 changed the title Code Quality: Introduced ICommonDialogService Fix: Fixed a crash that would occur when opening file pickers and Files was running as admin May 17, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-OpenFileDialogWorkaround branch May 17, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Opening file picker as admin will cause crash (WinAppSdk issue)
2 participants