-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed a crash that would occur when opening file pickers and Files was running as admin #15386
Merged
yaira2
merged 26 commits into
files-community:main
from
0x5bfa:5bfa/Fix-OpenFileDialogWorkaround
May 17, 2024
Merged
Fix: Fixed a crash that would occur when opening file pickers and Files was running as admin #15386
yaira2
merged 26 commits into
files-community:main
from
0x5bfa:5bfa/Fix-OpenFileDialogWorkaround
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
May 12, 2024
…m/0x5bfa/Files into 5bfa/Fix-OpenFileDialogWorkaround
yaira2
reviewed
May 15, 2024
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
yaira2
reviewed
May 15, 2024
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
yaira2
reviewed
May 15, 2024
yaira2
reviewed
May 15, 2024
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
For application background and album background file picker, I’m working on improving filter UX. Should be addressed by today (UTC+9) |
I discovered an issue
|
…m/0x5bfa/Files into 5bfa/Fix-OpenFileDialogWorkaround
There was a invalid cast, fixed. |
yaira2
approved these changes
May 17, 2024
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
May 17, 2024
7 tasks
yaira2
changed the title
Code Quality: Introduced ICommonDialogService
Fix: Fixed a crash that would occur when opening file pickers and Files was running as admin
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing a bug, but also contains performance improvements because of calling native API.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
NetworkConnectionDialog
FileSaveDialog
FileOpenDialog