Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Update structure of storage projects #15407

Merged
merged 4 commits into from
May 16, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 16, 2024

Summary

  • Added IWatcher, IDeviceWatcher, ITrashWatcher and IFolderWatcher
  • Updated the codebase structure of both of Core and App
  • Added license header
  • Removed unneeded using directives

We have too many watchers that are specific to each purpose. We can merge those into each service and remove those below. This is a part of work reducing duplicated functionality classes

  • RecycleBinManager
  • FileTagsManager
  • DrivesViewModel
  • DeviceManager
  • WindowsStorageDeviceWatcher & IStorageDeviceWatcher
  • QuickAccessManager
  • LibraryManager
  • WSLDistroManager

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app

Screenshots

Core App
image image

yaira2
yaira2 previously approved these changes May 16, 2024
@yaira2
Copy link
Member

yaira2 commented May 16, 2024

@0x5bfa did you confirm that the various watchers are functioning properly?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 16, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented May 16, 2024

did you confirm that the various watchers are functioning properly?

Those aren't used at all, just added. If we want to use, we have to fix them first #14572. THey have for each own implementation, making maintainability worsen.

Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
@yaira2 yaira2 merged commit 9b4aec7 into files-community:main May 16, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-IWatcher branch May 17, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants