-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundles!! #2881
Bundles!! #2881
Conversation
This looks awesome. |
@d2dyno1 This looks great! Nice work. @yaichenbaum We should look towards making the recent items list and new Bundles section arranged horizontally, so they can be side by side. Most likely we'll only make them horizontal when both are enabled. Thoughts are welcome. |
@duke7553 That level of customization will likely be part of a larger effort to give users more customization for the widgets on the home page. Ideally users should be able to choose between different widgets sizes and choose where on the home page to display them. |
Files/Interacts/Interaction.cs
Outdated
/// <param name="itemType"></param> | ||
/// <param name="openSilent">Determines whether history of opened item is saved (... to Recent Items/Windows Timeline)</param> | ||
public async Task<bool> OpenPath(string path, FilesystemItemType? itemType = null, bool openSilent = false) | ||
// TODO: This Function is not ready yet! It is not fully merged from OpenSelectedItems() because of ListedItem restriction, halp needed plz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on the restriction you need help with here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I originally tried to convert path to ListedItem
, since there is no function for getting ListedItem
from path, I had to rewrite the entire OpenSelectedItems()
to navigate by provided path; There are some checks in this function that determine whether an item is an hiddenItem, shortcutItem etc. they are not present in OpenPath
function though - since these checks are bound to ListedItem
- that's what I need help with
Not sure having two items per column will work, especially for longer folder names. Perhaps a vertical list of items? I would suggest no backing plate to give a cleaner look. If the bundle was really large, maybe there should be a flyout button to pop out a list, a UI for re-arranging the list - and long lists should have at the bottom some text like |
I think the backing plate makes it easier to distinguish between 2 bundles and also fits to the design of the other widgets |
Current Bundle limit is 8 items |
Bundles sounds like a group of folders. Do they all open when the bundle is clicked - or is it just a list of folders you can click individually? There will probably need to be UI to re-arrange bundle items, add and removing etc. ContentDialog? I would say, better to have each item clickable to open as a new tab, and also a Right Click menu to Open all as tabs, or Open all in a new window |
Clicked items open individually. You can add both folders and files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a crash when importing wrong .json file.
@tsvietOK everything seems to work now. Anything more left on your list? |
@d2dyno1 There is no icon of shortcut file. |
@tsvietOK I've removed the option for adding shortcut files. I've put it in the "Future Bundles PR" list. |
Can you add reveal effect for the bundle menu button? |
@tsvietOK This is how it would look like: But I still prefer it without the reveal. |
😕 bruh, I liked the reveal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 🎊 |
@d2dyno1 Looks like there is no |
It would be nice if we can display bundles at the first row. Is there a way to customize or remove Folders on the home page? |
You can hide the folders widget from the button in top right. |
This PR brings Bundles Widget - Grouped containers of files/folders for quick access from the home page.
Example usage
Features of this PR
IDisposable
ReadyBaseJsonSettingsViewModel
for serialization!DynamicDialog
for dynamic dialogs - any dialog could be created off of it! (MVVM Ready)Interaction.OpenSelectedItems
->Interaction.OpenPath
Things yet to do
Interaction.OpenSelectedItems()
withInteraction.OpenPath()
[Help wanted]Screenshots (constantly updated)
Future Bundles PR #3637
OpenPath
navigationCloses #1465