-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bundles!! #2881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bundles!! #2881
Changes from all commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
e4384cb
Bundles!!
d2dyno1 fb486b8
Added "Add Bundle" UI
d2dyno1 ed8a3e7
Fix Build error
d2dyno1 427524c
Added no bundle contents text info
d2dyno1 b09f99e
Added setting for disabling/enabling Bundles
d2dyno1 f27923b
Added option to remove, rename existing bundles
d2dyno1 4379c51
Added the option to remove items from Bundles
d2dyno1 8fb14ee
Removed selection animations and fixed item click flyout
d2dyno1 fb40017
Added folder icons
d2dyno1 a6bb3bf
Added Icon + Minor Changes
d2dyno1 2cf82c9
File Icons are now properly displayed
d2dyno1 deadac7
Folder Icons are now properly shown
d2dyno1 1062cd3
Added keyboard events to rename textbox + applied design suggestion
d2dyno1 0a7b862
Show file names with extension
d2dyno1 4d2be66
Update empty Bundle info text
d2dyno1 6f3697e
CodeFactor
d2dyno1 17e0831
Display current bundle name in textbox when renaming
d2dyno1 7659c6d
Centered Items
d2dyno1 6e81af8
Bigger font for bundle options
d2dyno1 3c18e0a
Made item spacing bigger
d2dyno1 d47561a
Fine-tuned alignment
d2dyno1 6a382b3
Fixed item text wrapping
d2dyno1 ea3e538
Added the option to open folders in new tab
d2dyno1 456797d
Added the option to open item's location
d2dyno1 602da73
Redesigned the "No Bundles" text
d2dyno1 7b24753
Simple button
d2dyno1 bbcac55
View is now properly updated when removing bundles/items
d2dyno1 2236afb
No Items in Bundle is now properly hidden and shown
d2dyno1 de6c8f6
Big "Add Bundle" button is now properly shown
d2dyno1 fea3c73
Quick Fix lol
d2dyno1 334ab67
Drag and drop now covers entire Bundle area
d2dyno1 afaee72
Fixed widget width
yaira2 75bf3d3
Fixed item width
yaira2 7dafd67
Replace RelayParameterizedCommand with RelayCommand<>
d2dyno1 8e90512
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 b2fa0ca
Updated margin
yaira2 c40940b
Fix build error
d2dyno1 9c24f5a
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 9adb31d
Added text wrapping
yaira2 dc114a6
Update IDisposable
d2dyno1 ac72d01
Fixed corner radius
yaira2 425554e
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 8688da8
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 ad4455c
Updated description to be more precise
d2dyno1 bb8dceb
Added e.Handled = true
d2dyno1 10d8d4d
Fix codestyle oof
d2dyno1 e4be9a1
Removed items move to home page restriction
d2dyno1 a2fb2ca
Quick fixes and improvements
d2dyno1 90c364a
Removed duplicate code
d2dyno1 32e5904
Added shortcut item check but no implementation
d2dyno1 d7f0626
Implemented OpenPath() isShortcutItem
d2dyno1 9cd3d48
Filled arguments for shortcutItem
d2dyno1 152b8f1
:tada: Replaced OpenSelectedItems with OpenSelectedItems2
d2dyno1 5675539
Simplified code
d2dyno1 8c6f90b
Removed try-catch
d2dyno1 5fe1519
Fix bug with opening hidden dirs
d2dyno1 87f459a
Added some safety checks
d2dyno1 1a06546
no _
d2dyno1 3d3b1fb
Improved xaml
yaira2 f96ae73
Removed OpenSelectedItems, and replaced it with OpenSelectedItems2
d2dyno1 6b06170
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 44b54c1
Added some checks + changed indentation to spaces
d2dyno1 d3999c9
Fixed item overflow
d2dyno1 005e329
Changed Bundle Height to 256
d2dyno1 d4e0b18
Remove sVariables
d2dyno1 969318a
Codestyle fixes
d2dyno1 ca88006
mru -> mostRecentlyUsed
d2dyno1 bb4271c
codestyle
d2dyno1 0de9251
Decoupled JsonSettingsViewModel
d2dyno1 9b87571
Renamed JsonSettings -> WidgetsSettings
d2dyno1 84761f9
Marked BaseJsonSettingsViewModel as abstract
d2dyno1 d04dcf1
Added brackets :)
d2dyno1 2fbc12c
Removed Highlight effect from grids
d2dyno1 5ca9ca0
Merge branch 'master' into master
d2dyno1 b51097f
Consistent Bundle uppercase names
d2dyno1 9cf6247
Increase spacing
d2dyno1 d8418bf
Prep for Bundles exporting/importing
d2dyno1 88c2082
Prep for DynamicDialog
d2dyno1 1629c20
Improvements to DynamicDialog
d2dyno1 4f3cee5
Added the option to import/export bundles
d2dyno1 efc07a9
Minor improvements
d2dyno1 dd7ffc7
Merge branch 'main' into master
d2dyno1 b996c5a
Replaced export/import DynamicDialog to FilePicker
d2dyno1 16f1c9f
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 6e13c5c
DynamicDialog and overall code improvements
d2dyno1 7542751
Added KeyDown event to DynamicDialog
d2dyno1 3fcfb41
Show dialog while renaming a Bundle
d2dyno1 674d3ed
Removed unnecesary code
d2dyno1 7196b07
Added translation resource strings
d2dyno1 c291f82
Fixed menu placement
yaira2 1ee23b9
Added rounded corners to dialog buttons
d2dyno1 1ea018b
Merge branch 'master' of https://github.com/d2dyno1/Files
d2dyno1 26951fc
Fix character cutting and improved design consistency
d2dyno1 4df8f23
Fixed translation error
d2dyno1 dfb7545
Update Files/Views/SettingsPages/Widgets.xaml
yaira2 6b95cd6
Updated strings
yaira2 bcc7d63
Updated strings
yaira2 7ef9518
Removed old string
yaira2 83adf70
Code Improvements
d2dyno1 a2c169a
Some refactor
tsvietOK be7c8fd
Fixed import crash, removed unnecesary code
d2dyno1 2414a67
Use FileSavePicker
d2dyno1 44076a9
Added DynamicDialog default implementation
d2dyno1 c3aa798
Applied reveal effect to Bundles Options button
d2dyno1 d74593f
Shortcut items don't get added
d2dyno1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
using System; | ||
using Windows.UI.Xaml; | ||
using Windows.UI.Xaml.Data; | ||
|
||
namespace Files.Converters | ||
{ | ||
public class VisiblityInvertConverter : IValueConverter | ||
d2dyno1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
public object Convert(object value, Type targetType, object parameter, string language) | ||
{ | ||
return (Visibility)value == Visibility.Visible ? Visibility.Collapsed : Visibility.Visible; | ||
} | ||
|
||
public object ConvertBack(object value, Type targetType, object parameter, string language) | ||
{ | ||
throw new NotImplementedException(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
<ContentDialog | ||
x:Class="Files.Dialogs.DynamicDialog" | ||
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
xmlns:icore="using:Microsoft.Xaml.Interactions.Core" | ||
xmlns:i="using:Microsoft.Xaml.Interactivity" | ||
mc:Ignorable="d" | ||
Title="{Binding TitleText, Mode=OneWay}" | ||
DefaultButton="Primary" | ||
CornerRadius="4" | ||
PrimaryButtonText="{Binding PrimaryButtonText, Mode=OneWay}" | ||
SecondaryButtonText="{Binding SecondaryButtonText, Mode=OneWay}" | ||
CloseButtonText="{Binding CloseButtonText, Mode=OneWay}" | ||
PrimaryButtonStyle="{StaticResource AccentButtonStyle}" | ||
SecondaryButtonStyle="{StaticResource DefaultButtonStyle}" | ||
CloseButtonStyle="{StaticResource DefaultButtonStyle}"> | ||
|
||
<i:Interaction.Behaviors> | ||
<!-- No need to specify CommandParameter - `e` is passed by default --> | ||
<icore:EventTriggerBehavior EventName="PrimaryButtonClick"> | ||
<icore:InvokeCommandAction Command="{Binding PrimaryButtonCommand, Mode=OneWay}" /> | ||
</icore:EventTriggerBehavior> | ||
<!-- No need to specify CommandParameter - `e` is passed by default --> | ||
<icore:EventTriggerBehavior EventName="SecondaryButtonClick"> | ||
<icore:InvokeCommandAction Command="{Binding SecondaryButtonCommand, Mode=OneWay}" /> | ||
</icore:EventTriggerBehavior> | ||
<!-- No need to specify CommandParameter - `e` is passed by default --> | ||
<icore:EventTriggerBehavior EventName="CloseButtonClick"> | ||
<icore:InvokeCommandAction Command="{Binding CloseButtonCommand, Mode=OneWay}" /> | ||
</icore:EventTriggerBehavior> | ||
<!-- No need to specify CommandParameter - `e` is passed by default --> | ||
<icore:EventTriggerBehavior EventName="KeyDown"> | ||
<icore:InvokeCommandAction Command="{Binding DynamicKeyDownCommand, Mode=OneWay}" /> | ||
</icore:EventTriggerBehavior> | ||
</i:Interaction.Behaviors> | ||
|
||
<Grid RowSpacing="25"> | ||
<Grid.RowDefinitions> | ||
<RowDefinition Height="Auto"/> | ||
<RowDefinition/> | ||
</Grid.RowDefinitions> | ||
|
||
<!-- Subtitle --> | ||
<TextBlock | ||
Text="{Binding SubtitleText, Mode=OneWay}" | ||
HorizontalAlignment="Left" | ||
VerticalAlignment="Center" | ||
Grid.Row="0" /> | ||
|
||
<!-- The dynamic content control --> | ||
<ContentControl | ||
Content="{Binding DisplayControl, Mode=OneWay}" | ||
VerticalAlignment="Stretch" | ||
HorizontalAlignment="Stretch" | ||
VerticalContentAlignment="Stretch" | ||
HorizontalContentAlignment="Stretch" | ||
Grid.Row="1" /> | ||
</Grid> | ||
</ContentDialog> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.