Made some enhancements to the Bundles widget

[d2dyno1]

This PR polishes and fine-tunes Bundles PR. This is the final part that completes Bundles

Things yet to do

• Option to rearrange Bundle items by dragging
• Select items upon OpenPath navigation
• Ability to rearrange Bundles
• Support for adding shourtcut files [Feature request] Add shortcut support to Bundles #3270
• Display warning when creating a Bundle if the name already exists Warning about existed bundle name #3449
• Add option to open folders in bundle in new pane
• Fix memory leaks
• Improve DynamicDialog (auto focus on DisplayControl) Autofocus on text field #3724

Closes #3449
Closes #3270
Closes #3724

[R3voA3]

Would it be in the scope of this PR to add context menu entries to add an item to a bundle?

[crashmit]

Suggestion to improve bundles further:

Currently there is no option to open bundle items in a new pane, if I'm not mistaken. Have you thought about implementing this so far?

[d2dyno1]

Would it be in the scope of this PR to add context menu entries to add an item to a bundle?

Hmm, this is a bit of work and actually exceedes the scope of this PR. Drag & drop already works with bundles so there's no point for now to add context menu option

[d2dyno1]

Suggestion to improve bundles further:

Currently there is no option to open bundle items in a new pane, if I'm not mistaken. Have you thought about implementing this so far?

Sounds like a good idea. I'll work on that

[R3voA3]

Would it be in the scope of this PR to add context menu entries to add an item to a bundle?

Hmm, this is a bit of work and actually exceedes the scope of this PR. Drag & drop already works with bundles so there's no point for now to add context menu option

Fair enough, although Drag & Drop doesn't work reliably.

[yaira2]

Nice work! LGTM

[d2dyno1]

This one is important. Currently we have a memory leak in Bundles because IDisposable.Dispose() in YourHome.xaml.cs is not called.

@yaichenbaum fyi

[d2dyno1]

The solution is already in place but YourHome.Dispose() needs to be called which exceeds the scope of this PR :)

[gave92]

Support for adding shourtcut files

How do you add shortcut files to a bundle since shortcuts can't be dragged?
Edit: you can from explorer

Option to rearrange Bundle items by dragging

Seems like I'm not able to drag items inside bundles, I can only rearrange bundles

[d2dyno1]

Option to rearrange Bundle items by dragging

Seems like I'm not able to drag items inside bundles, I can only rearrange bundles

It does work, but you must hold the item at the very edge of it. The reason it can't be dragged when directly clicking on it is because the button is clicked instead since it covers the entire gridviewrow area.

@gave92 Do you happen to know a solution to such problem?

[gave92]

@gave92 Do you happen to know a solution to such problem?

What about removing the Button and adding IsItemClickEnabled/ItemClick to the GridView?

[d2dyno1]

@gave92 Do you happen to know a solution to such problem?

What about removing the Button and adding IsItemClickEnabled/ItemClick to the GridView?

How would flyout work with it?

[gave92]

I'm positive ContextFlyout can be set on any element (e.g a Grid) not just Buttons (or you can switch to FlyoutBase.AttachedFlyout + RightTapped event but there should be no need)

[d2dyno1]

@gave92 fixed! Thank you! 😊