Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom CNAME Support Missing #40

Closed
selfsimilar opened this issue May 30, 2019 · 1 comment
Closed

Custom CNAME Support Missing #40

selfsimilar opened this issue May 30, 2019 · 1 comment

Comments

@selfsimilar
Copy link
Contributor

the JavaScript API client has custom CNAME support, though it looks like none of the other API clients include support.

Is this feature specifically omitted, or just not implemented yet? It seems like it would be relatively straightforward to implement.
@selfsimilar
Copy link
Contributor Author

I've deployed to production the code changes represented by the latest commit in my fork/pull request #41. I'd say that it's functionally ready to merge. I'm happy to make any changes based on code review.

@kyuss kyuss closed this as completed in 4058b58 Apr 14, 2020
kyuss added a commit that referenced this issue Apr 14, 2020
@kyuss
Merge pull request #41 from selfsimilar/contrib/issue-40
d89b0b7 
fix #40 : Add support for custom CNAME
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@selfsimilar