Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-4916 and FS-5253 add workflows support for uploading and add tests for these functionalities #35

Merged
merged 11 commits into from
Apr 26, 2019

Conversation

yousefiparsa
Copy link
Contributor

@yousefiparsa yousefiparsa commented Apr 16, 2019

This Pull Request contains major changes such as:

  • Changing entirely upload procedure from external URL

  • Add store parameters support to upload procedure from external URL

  • Add workflows support for uploading from external URL

  • Add workflows support for uploading from local file (multipart=True)

  • Add test for uploading from external URL including store parameters

  • Add test for multipart uploading a local file with workflows parameters

@yousefiparsa yousefiparsa requested a review from bkwi April 16, 2019 20:27
@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage increased (+0.2%) to 95.418% when pulling 5dd8991 on feature/fs-4916_add_workflows into e1773e2 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 94.851% when pulling b755618 on feature/fs-4916_add_workflows into e1773e2 on develop.

filestack/utils/utils.py Outdated Show resolved Hide resolved
filestack/utils/upload_utils.py Outdated Show resolved Hide resolved
filestack/models/filestack_client.py Outdated Show resolved Hide resolved
@yousefiparsa yousefiparsa requested a review from bkwi April 25, 2019 17:20
@bkwi bkwi merged commit f4d54c4 into develop Apr 26, 2019
@bkwi bkwi deleted the feature/fs-4916_add_workflows branch April 26, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants