Render children as buttonText replacement #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuxyz
reviewed
Apr 6, 2017
src/ReactFilestack.jsx
Outdated
| const Tag = link ? 'a' : 'button'; | ||
| return ( | ||
| <Tag | ||
| name="filestack" | ||
| onClick={this.onClickPick} | ||
| className={buttonClass} | ||
| > | ||
| {buttonText} | ||
| {!children && buttonText} |
There was a problem hiding this comment.
Since you want to give higher priority to children, what about replacing
{!children && buttonText}
{children}
with
{children || buttonText}
I hope I understood your intentions well.
There was a problem hiding this comment.
Yes this is exactly what I want to do. Actually I would prefer to replace buttonText by children but I don't want to break compatibility.
|
This is great, would it be possible to bump npmjs with this new version ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usefull to display a custom button with an icon.