Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for console errors in e2e #26

Closed
filipesilva opened this issue Nov 15, 2019 · 4 comments · Fixed by #30
Closed

Add a check for console errors in e2e #26

filipesilva opened this issue Nov 15, 2019 · 4 comments · Fixed by #30
Labels
released

Comments

@filipesilva
Copy link
Owner

We should check if there are any console errors in the browser for the app e2e.

According to getgauge/taiko#913, https://github.com/saikrishna321/taiko-diagnostics#logconsoleinfo-command should do it.
@filipesilva
Copy link
Owner Author

taiko-diagnostics can print the logs, but doesn't expose them for checks. Logged a feature request: saikrishna321/taiko-diagnostics#149

@saikrishna321
Copy link

saikrishna321 commented Nov 19, 2019 •
edited
Loading

@filipesilva I have fixed this in the latest release

saikrishna321/taiko-diagnostics#149

filipesilva added a commit that referenced this issue Nov 19, 2019
@filipesilva
fix: check no errors are logged on e2e
8a23527 
Fix #26
@filipesilva filipesilva mentioned this issue Nov 19, 2019
Merged
filipesilva added a commit that referenced this issue Nov 19, 2019
@filipesilva
fix: check no errors are logged on e2e
81041a7 
Fix #26
@filipesilva
Copy link
Owner Author

I used it in #30 and it works great, thank you!

@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check no errors are logged on e2e filipesilva/create-cljs-app
2 participants
@saikrishna321 @filipesilva