Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action file #60

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Add github action file #60

merged 1 commit into from
Jan 22, 2021

Conversation

errnesto
Copy link
Collaborator

@errnesto errnesto commented Nov 23, 2020

I think this is all you need to create a github action out of this.

As an alternative it would be possible to list all the arguments as github action arguments…
But doing it like this, it's easier to keep the action up to date and we keep the same interface which is already documented.

I created the action here: https://github.com/wunderundfitzig/linkcheck-action because I need to use it in a project.
I'm happy to hand over the repository if it would be better to keep the action in a seperate repo.
I would depricate that repo if a official action exists :-)

I guess this closes #46

@filiph
Copy link
Owner

filiph commented Jan 22, 2021

Sorry this took so long. I hoped to have time to take a closer look at GitHub Actions but, to be completely honest, I don't think I'll have the time anytime soon. This change looks good, so I'm merging.

Thank you for the contribution! Please let me know if it works on your end.

@filiph filiph merged commit 1090286 into filiph:master Jan 22, 2021
@filiph
Copy link
Owner

filiph commented Jan 22, 2021

Ok, follow up question. Here's what github tells me about the action:

Screen Shot 2021-01-21 at 10 50 38 PM

What's a good naming convention for such an action?

@errnesto
Copy link
Collaborator Author

errnesto commented Jan 22, 2021

Hm I don't really know any naming conventions… all I can do is copy what they write here (https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace) :-)

The name in the action's metadata file must be unique.

  • The name cannot match an existing action name published on GitHub Marketplace.
  • The name cannot match a user or organization on GitHub, unless the user or organization owner is publishing the action. For example, only the GitHub organization can publish an action named github.
  • The name cannot match an existing GitHub Marketplace category.
  • GitHub reserves the names of GitHub features.

So I guess linkcheck is taken by some user or organisation… I delisted my version of your action so maybe linkcheck-action will work now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions
2 participants