Improve behavior around --show-redirects
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR filiph#54 added a `--show-redirects` flag! But although it adds a redirects count to the summary, it won't show the details about WHICH links were redirected unless there was *also* at least one error or warning. So if you want to actually update your redirected links, you need to temporarily break an unrelated link first. 😆 This commit adds "they requested redirects, and there was at least one redirect" to the list of conditions that can trigger a full report.
If the user asked for alerts on redirects, they presumably want a nonzero exit code so their CI etc. will recognize redirects as a problem. Redirects seem more like warnings than errors, since they work fine but are undesirable.
|
Fantastic, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #54 added a
--show-redirectsflag! But the implementation didn't seem quite complete:unless there was also at least one error or warning. So if you want to
actually update your redirected links, you need to temporarily break an
unrelated link first. 😆
So, this PR has a commit to deal with each of those.