Fix passing multiple arguments to github action #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up my original contribution… When one would pass more than one argument e.g.
arguments: 'example.com --skip-file skipfile.txt'
to the github action it would fail with:This is because github action arguments can only be strings, but when we pass them as
args
to the dockerfile the docker cmd looks like this:cmd=["https://qa.ems.press --skipfile hui.txt"]
The workaround I found is overwriting the docker
entrypoint
via the actions file. There I can just expand theinputs.arguments
variable…This should close #72