-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include prettier fonts #248
Conversation
jacobbednarz
commented
Nov 27, 2014
- Adds consistent font
- CSS tidy up
This standardises the font stack to be the same across the board.
This is just a general tidy up to fix up the loose indents, spacing and conventions.
Why have you changed the indentation? Can you clean it up, while retaining 4 spaces for indentation? |
The file itself didn't show a particular way so I just went with my usual defaults. Happy to update this to be 4 space indents. |
Looking at the original file in blame mode, it's clear that it should have been 4 spaces. Other contributors seem to have used different indentations. |
It's really doesn't matter what's the existing style, even if it's messy as it's in this file. All the rest is suggesting cleanup. And while it's possibly a very good suggestion, it's not helping to have to decide on it together with the great suggestion of adding fonts. |
While this is true I don't think it should be the contributors responsibility to sift though blame views and history in order to find out which coding style was used first. If it's not evident from your code or guidelines which is the preferred style then I think you can't expect people to pick up in this.
Understood. This type of thing I would usually break up but as the changes were more formatting related, I just separated them into individual commits. If you really want these broken up into their own pull requests I can also do that. Will keep this in mind for future pull requests. |
Updated to use 4 space indents. |