publish finch artifacts using github actions

[arron-green]

worked with @rpless to prepare deploying artifacts with github actions.

still needs a github actions file to trigger workflow

[joroKr21]

I think we need to revert #1459 and #1460 first

[arron-green]

this is also failing due to scalafix errors. running sbt validate shows the errors

fixed locally with sbt scalafixAll

[joroKr21]

A no wait, you brought back the build here 🤔

[arron-green]

got past the scalafix issue and now validate is failing due to

[error] (refined / Compile / scalafmtCheck) org.scalafmt.sbt.ScalafmtSbtReporter$ScalafmtSbtError: scalafmt: Invalid config: Default dialect is deprecated; use explicit: [sbt0137,sbt1,scala211,scala212,scala212source3,scala213,scala213source3,scala3]
[error] Also see https://scalameta.org/scalafmt/docs/configuration.html#scala-dialects"

[rpless]

The config is probably out of date. Dialect is a new thing. https://scalameta.org/scalafmt/docs/configuration.html#scala-dialects. We probably want scala213.

[joroKr21]

You need to add runner.dialect = scala213 - it should work also fine with Scala 2.12

[arron-green]

left to do

• verify openssl works with the encryption secret
• revert Release 0.33.0 #1460

[joroKr21]

A few more nits to hammer.
Another question - I think once merged this it would release 0.33.0 - is this desired?

[joroKr21]

I think we can just delete those and inline os and java version

[vkostyukov]

Any chance we can undo these comment changes so it's easier to review?

[vkostyukov]

Or maybe open a separate PR with code style changes?

[arron-green]

yeah. it was just the output of running scalafmt and scalafix

[vkostyukov]

Looks reasonable to me! Thank you so much, @arron-green and @rpless and @joroKr21 for these changes!

[rpless]

This PR looks good to me as well, however there is one minor problem that we've uncovered. I was able to confirm that the encryption password works for the files on a mac, however when I tried on an ubuntu machine it failed with the following:

| *** WARNING : deprecated key derivation used.
| Using -iter or -pbkdf2 would be better.
| bad decrypt
| 281473334143456:error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt:../crypto/evp/evp_enc.c:615:

A security engineer at work pointed me to this and said the problem was most likely that the files were originally encrypted with libressl and that apparently doesn't work with versions of ssl that ship with ubuntu.
I've also used https://github.com/nektos/act to test the Github Action locally and the files fail to decrypt with the same error in the container that github actions runs. @arron-green did some digging and found this workaround which involves re-encrypting the files.
So here is what I propose:

• We revert the release commit
• We then merge this PR
• We then merge Fix formatting (scalafmt & scalafix) #1465
• I'll push a commit with those files re-encrypted such that the openssl in the github actions container can decrypt them
• We attempt the release again

If folks are good with this plan let me and I can get it started.

[arron-green]

@rpless sounds good to me. i'll update the build script to include the openssl options to include -salt -pbkdf2. i can comment the rest of the build to only include the decrypt portion to test with github actions

[arron-green]

i realized after i pushed my last update that the openssl section would only run on merge. moved to the top to test out that portion

[arron-green]

@rpless script is ready for the updated files

[rpless]

Ok I'll get started on that process I described.

[joroKr21]

Now you just need to update the branch I think