Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint metadata ADT and specs #880

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergeykolbasov
Copy link
Collaborator

Related to #581

@vkostyukov @rpless please, take a look. It's the first iteration and I'd be glad to get some feedback on this.

@codecov-io
Copy link

codecov-io commented Dec 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9f677b3). Click here to learn what that means.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #880   +/-   ##
=========================================
  Coverage          ?   79.47%           
=========================================
  Files             ?       52           
  Lines             ?      794           
  Branches          ?       35           
=========================================
  Hits              ?      631           
  Misses            ?      163           
  Partials          ?        0
Impacted Files Coverage Δ
core/src/main/scala/io/finch/endpoint/path.scala 76.31% <0%> (ø)
...tee/src/main/scala/io/finch/iteratee/package.scala 91.3% <0%> (ø)
core/src/main/scala/io/finch/endpoint/cookie.scala 50% <100%> (ø)
...rc/main/scala/io/finch/syntax/EndpointMapper.scala 100% <100%> (ø)
core/src/main/scala/io/finch/endpoint/header.scala 64.7% <100%> (ø)
...e/src/main/scala/io/finch/endpoint/multipart.scala 77.41% <100%> (ø)
core/src/main/scala/io/finch/endpoint/param.scala 79.41% <100%> (ø)
core/src/main/scala/io/finch/Endpoint.scala 67.83% <28.57%> (ø)
core/src/main/scala/io/finch/endpoint/body.scala 58.33% <50%> (ø)
core/src/main/scala/io/finch/Endpoints.scala 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f677b3...e7c2fdd. Read the comment docs.

lbordowitz added a commit to lbordowitz/finch that referenced this pull request Nov 12, 2019
This is based in-part on the work of Sergey Kolbasov:
finagle#880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants