Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dkong] Jump score fx sounds cut and/or partially repeated #1799

Closed
vanfanel opened this issue Jun 8, 2024 · 4 comments
Closed

[dkong] Jump score fx sounds cut and/or partially repeated #1799

vanfanel opened this issue Jun 8, 2024 · 4 comments

Comments

@vanfanel
Copy link

vanfanel commented Jun 8, 2024

In Donkey Kong, jump fx is a sample in FBNeo.
However, the fx that plays when jumping over barrels/enemys/gaps is not a sample, and it sounds very incorrect: some times it sounds correctly, but other times it will be cut, play again partially after having played, etc...

Steps to reproduce: stay in a position on the first stage, and repeatedly jump over incoming barrels (it's very easy if you stay in the same position). You will notice that the sound effect is not correct sometimes.

@dinkc64
Copy link
Collaborator

dinkc64 commented Jun 10, 2024

Hi vanfanel,
I'm having trouble reproducing the problem on my side.
Could you please make a recording of this problem? I've jumped over about 100 barrels and it sounds exactly the same every time for me.

best regards,

  • dink

@vanfanel
Copy link
Author

@dinkc64 Thanks for trying to take a look at this bug.
I have recorded the audio:

jump_audio.zip

You can see that first "jump-over-barrel" sound is correct, but second is not.

@vanfanel
Copy link
Author

@dinkc64 Sorry for annoying you with this: I tested latest stable MAME 0.266 and the MiSTer FPGA implementation, and Donkey Kong jump-over-barrel sound has this variable sound there too. It's not an FBNeo bug. Probably real hardware sounds that bad too.

Again, sorry for wasting your time on this...

@dinkc64
Copy link
Collaborator

dinkc64 commented Jun 11, 2024

no problem, it's good to notice things like that because you never know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants