Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 #67

Merged
merged 154 commits into from
Oct 20, 2022
Merged

1.0.0 #67

merged 154 commits into from
Oct 20, 2022

Conversation

xnerhu
Copy link
Contributor

@xnerhu xnerhu commented Sep 8, 2022

This pr includes a total refactor of bot detection along side standalone implementation of collectors and detectors.

@Finesse
Copy link
Member

Finesse commented Oct 15, 2022

xnerhu requested review from Valve, r-valitov, Romchela and Finesse

@xnerhu 1 unresolved notice from me: #67 (comment)

@Finesse
Copy link
Member

Finesse commented Oct 15, 2022

If you want to check the Open CDN connection before releasing v1.0.0, you can publish this code (ofter merging the PR to NPM) as a beta version.

Copy link
Contributor

@Valve Valve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be providing incremental readme improvements via future PRs

@@ -1,16 +1,49 @@
import packageInfo from '../package.json'
Copy link
Member

@Finesse Finesse Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole package.json content has got into the distributive files because of this. Not a problem actually, just an excess code in the distributive files. Though it's removed by Terser (will be removed in end projects and on Open CDN).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it in a separate pull request.

package.json Outdated Show resolved Hide resolved
@Finesse
Copy link
Member

Finesse commented Oct 19, 2022

I also recommend adding a CI step that checks that BotD works well in server-side-rendering applications. It was an issue a couple times in FingerprintJS. The check can be implemented with a single command: https://github.com/fingerprintjs/fingerprintjs/blob/e1696687d6a1ea6ebb9008c24f8902e929db03f6/package.json#L44

This is not necessary to do in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants