Extended charset encoding detection options #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PRs also fixes #1, if you pass a string as parameter is not handled as default encoding. |
|
Thank you for the fixes and additions! Are you interested to be a collaborator on this module? |
|
Published as 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@finnp when i was trying to use your module to convert a file from srt to vtt I found your default limits to detect encoding (only use first line) was not enough because srt's first line is always
1so the detection part was useless.I added two options to improve encoding detection
newlineUse input text until newline is reached to detect encoding (defaulttrue)detectSizeMaximum size from input to detect encoding (default65535)as you can see the given defaults behaves exactly as your current implementation, making the changes backward compatible.