initial commit for 2.0 support #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nkolba
commented
Oct 21, 2022
nkolba
commented
- added 2.0 API side by side with 1.2
- stubbed out 2.0 in preload
- internalized type dependencies for 1.2
|
WIP. Ran into problems with type usage conflicts between 1.2 and 2.0. |
Looks really promising nonetheless! Looking forward to chatting about it later |
|
What he said ☝️ |
sebbenmbarek
approved these changes
Oct 25, 2022
robmoffat
reviewed
Oct 25, 2022
| "@fontsource/roboto": "^4.5.3", | ||
| "@mui/icons-material": "^5.4.4", | ||
| "@mui/material": "^5.4.4", | ||
| "electron-fetch": "^1.7.4", | ||
| "electron-updater": "^4.6.5", | ||
| "fastify": "^3.27.2", | ||
| "fdc3-1.2": "npm:@finos/fdc3@^1.2.0", |
robmoffat
approved these changes
Oct 25, 2022
| @@ -1,7 +1,11 @@ | |||
| import { View } from './view'; | |||
| import { getRuntime } from './index'; | |||
| import { BrowserWindow } from 'electron'; | |||
| import { FDC3App, IntentInstance, ResolverDetail } from './types/FDC3Data'; | |||
| import { | |||
There was a problem hiding this comment.
Is IntentResolver common to 1.2 and 2.0?
| @@ -14,7 +14,8 @@ | |||
|
|
|||
| "baseUrl": ".", | |||
| "paths": { | |||
| "/@/*": ["./src/*"] | |||
| "/@/*": ["./src/*"], | |||
| "/@main/*": ["../main/src/*"], | |||
There was a problem hiding this comment.
I think it's usual to leave off the / on /@main, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.