Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify intended behavior on void intent results #1004

Merged
merged 3 commits into from
May 25, 2023

Conversation

kriswest
Copy link
Contributor

resolves #1003

Clarifies description of IntentResolution.getResult() when the intent handler returned void (which is not an error)

@kriswest kriswest added bug Something isn't working docs Documentation api FDC3 API Working Group labels May 24, 2023
@kriswest kriswest requested review from a team May 24, 2023 17:22
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit afb80f6
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/646f7b23edfc4e00086684a8
😎 Deploy Preview https://deploy-preview-1004--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/api/DesktopAgent.ts Outdated Show resolved Hide resolved
@kriswest kriswest mentioned this pull request May 25, 2023
27 tasks
Co-authored-by: Hugh Troeger <htroeger@factset.com>
@kriswest kriswest merged commit 855e34c into master May 25, 2023
@kriswest kriswest deleted the 1003-clarify-getresult-on-resolve-to-void branch May 25, 2023 15:17
@bingenito bingenito mentioned this pull request Nov 6, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group bug Something isn't working docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify expected behaviour of IntentResolution.getResult() when IntentHandlers resolve to void
3 participants