Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify existing behavior of joinChannel and addIntentListener when joining a channel #454

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Sep 15, 2021

Resolves #418

Also:

  • shuffles sentence order in spec for clarity (doesn't change meaning)
  • switches examples using 'agent.' to 'fdc3.' for consistency
  • fixes a couple of minor formatting inconsistencies

…oining a channel

- shuffles sentence order in spec for clarity (doesn't change meaning)

-switches examples using 'agent.' to 'fdc3.' for consistency

- fixes a couple of minor formatting inconsistencies
@kriswest kriswest mentioned this pull request Sep 21, 2021
14 tasks
docs/api/ref/DesktopAgent.md Outdated Show resolved Hide resolved
Fix type in DesktopAgent docs for addContextListener

Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
@rikoe rikoe merged commit a2719fe into finos:master Oct 7, 2021
@kriswest kriswest deleted the ClarifyAutoBroadcastOnJoin branch October 8, 2021 11:31
@kriswest kriswest mentioned this pull request Oct 22, 2021
11 tasks
@kriswest kriswest added api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group cla-present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fdc3.joinChannel docs should explain expected behavior on joinChannel
3 participants