Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

589 intent proposal view interactions #625

Conversation

pauldyson
Copy link
Contributor

@pauldyson pauldyson commented Mar 14, 2022

resolves #589
There is a dependency between this PR and 600 View Profile ... just because some of the updates I make here build on the ones in View Profile (the update to intents/spec.md for example).

@mistryvinay
Copy link
Contributor

@finos/fdc3-maintainers any blockers for not approving this PR?

Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as #619 is merged first or in the same set (as it incorporates it).

@kriswest
Copy link
Contributor

Needs a CHANGELOG.md entry

@kriswest kriswest added this to the 2.0-candidates milestone May 17, 2022
@mistryvinay mistryvinay changed the base branch from master to context-data-and-intents-consolidated-update-branch May 23, 2022 14:27
mistryvinay added a commit that referenced this pull request May 23, 2022
…s' into context-data-and-intents-consolidated-update-branch

Merge PR #625 into consolidated PR branch
mistryvinay added a commit that referenced this pull request May 23, 2022
@mistryvinay mistryvinay merged commit ed51603 into finos:context-data-and-intents-consolidated-update-branch May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context Data & Intents Contexts & Intents Discussion Group enhancement New feature or request intents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent Proposal: ViewInteractions
3 participants