Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

553 Support v1 and v2 URLs in AppD spec #666

Merged

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Apr 19, 2022

resolves #553

Moves latest work on appD to /v2/ urls and restores /v1/ urls to 1.2 standard version of spec.
Will enable an appD implementation to serve both formats (if desired) to simplify migration.

Change agreed at meeting:

@kriswest kriswest changed the base branch from master to Appd-consolidated-update-branch April 20, 2022 14:33
@kriswest
Copy link
Contributor Author

@ggeorgievx FYI I'm targetting this PR at a branch so that we can collect up a number of changes to present to the SWG as a consolidated set (rather that 20 different PRs). Other rounds of changes from discussion groups have devolved into a nightmare of conflict resolutions (each merge created conflicts in all the remaining PRs) which I think we need to avoid this time ;-) particularly as I'm about to start on the spec re-org PR (#491) which will conflict with everything.

@kriswest
Copy link
Contributor Author

@ggeorgievx I'm going to go ahead and merge this into the consolidated branch as I need to base other PRs on it. Once done I'll raise a new WIP PR for the consolidated branch to enable review and tag you in that

@kriswest kriswest merged commit fc81042 into Appd-consolidated-update-branch Apr 20, 2022
@kriswest kriswest deleted the 553-appd-backwards-compatibility branch April 20, 2022 15:35
Copy link
Member

@ggeorgievx ggeorgievx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great @kriswest 🙌

I will look into the version (1.2 vs next) issue on the AppD part of the website.

@kriswest
Copy link
Contributor Author

Good luck - I thought it might be todo with the fact the appD page wasn't an HTML fragment (see website/pages/schemas/next/app-directory.html) as expected by the wrapPagesHtml option (was producing HTML with two html/head/body tags) but that wasn't it. Hence, I suspect its just a bug in docusaurus... it can be manually fixed in the generated HTML post-deployment (the version number is generated into the HTML not set by a script of anything similar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backwards compatibility support for the App Directory
2 participants