Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

603 Allow an App to retrieve its own metadata through getInfo() #726

Merged
merged 9 commits into from
May 27, 2022

Conversation

kriswest
Copy link
Contributor

resolves #603

As agreed at #683 this PR adds the calling app's AppMetadata to the ImplementationMetadata returned by fdc3.getInfo(), allowing an app to know its own own appId and instanceId without adding new functions to the desktop agent API.

@kriswest kriswest added enhancement New feature or request api FDC3 API Working Group labels May 19, 2022
@kriswest kriswest added this to the 2.0 milestone May 19, 2022
@netlify
Copy link

netlify bot commented May 19, 2022

Deploy Preview for lambent-kulfi-cf51a7 canceled.

Name Link
🔨 Latest commit 968002d
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/6291084a492fc90009941e0f

docs/api/ref/DesktopAgent.md Outdated Show resolved Hide resolved
docs/api/ref/DesktopAgent.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/ref/Metadata.md Outdated Show resolved Hide resolved
docs/api/ref/Metadata.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kriswest kriswest changed the title Allow an App to retrieve its own metadata through getInfo() 603 Allow an App to retrieve its own metadata through getInfo() May 20, 2022
@nkolba
Copy link
Contributor

nkolba commented May 23, 2022

@kriswest - curious about what an app might do with its own instanceId (or appId - if it didn't already know it).

@kriswest
Copy link
Contributor Author

@nkolba see commentary on the issue: #603 (comment)

It basically stems from the fact that an app doesn't necessarily know its own metadata (particularly if added to an appD that the author doesn't control) and can more easily discover the metadata of other apps than it can it's own. This change provides that metadata, allowing it to do things like spawning a copy of itself, recognizing its own metadata, differentiating itself from other instances (e.g. after calling findInstances), adding its details to log messages to enable better debugging etc.. These are not major use cases, but they have merit and I/we expect to find more of them in future.

docs/api/ref/Metadata.md Outdated Show resolved Hide resolved
docs/api/ref/Metadata.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
@kriswest kriswest merged commit 2cee3be into master May 27, 2022
@kriswest kriswest deleted the 603-add-appmetadata-to-implementationmetadata branch May 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an app to retrieve its own AppMetadata
5 participants