Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified spec requirements for registration of intent handlers #844

Merged
merged 6 commits into from
Nov 10, 2022

Conversation

kriswest
Copy link
Contributor

resolves #825

Clarified spec requirements for registration of intent handlers (SHOULD support interop.intents.listensFor in an appD record, may support other routes including dynamic registration at runtime)

…LD support in an appD record, may support other routes including dynamic registration at runtime)
@kriswest kriswest added docs Documentation api FDC3 API Working Group labels Oct 28, 2022
@kriswest kriswest requested review from hughtroeger and a team October 28, 2022 14:51
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
🔨 Latest commit ec0c3bf
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/636cd2cb9e9e5000093de10d
😎 Deploy Preview https://deploy-preview-844--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kriswest kriswest mentioned this pull request Oct 28, 2022
32 tasks
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has mixed capitalization of 'intent handlers' (Intent Handlers, Intent handlers, and intent handlers). but the content looks fine.

docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
@kriswest
Copy link
Contributor Author

kriswest commented Nov 3, 2022

Corrected capitalisation of Intent Handler in PR, largely by replacing with the actual type name IntentHandler and a link to its docs @greyseer256

docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
website/versioned_docs/version-2.0/api/spec.md Outdated Show resolved Hide resolved
@kriswest kriswest merged commit 501c7dd into master Nov 10, 2022
@kriswest kriswest deleted the clarify-dynamic-intent-registration branch November 10, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specs precision needed about intent handler and app metadata intents property
3 participants