-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating definition of otherConfig in fdc3.chart to use an array of context objects #985
updating definition of otherConfig in fdc3.chart to use an array of context objects #985
Conversation
✅ Deploy Preview for fdc3 canceled.
|
Is there a concern for backwards compatibility here? |
@rbruckheimer AFAIK ChartIQ is the main user of this type (although my information on that is not perfect), so you'd know better than I. Do you have clients using it currently? I wouldn't propose a change like this for an element that was standardized, however, this field was specifically for unstandardized data. A backwards-compatible change, that also doesn't have a redundant layer would be to use an object and create fields under it which are arrays, but divide them up by type, e.g. indicators, drawings, formulae, other (so that they have a purpose in organizing the config). OR you could keep Writing it out, seems like either the breaking change or deprecation and creating a new field seem like the best options. Let me know what you prefer and I can adjust the PR. |
Let's go with your proposal and we can change accordingly. |
@mistryvinay this should be ready for your review and merge into your consolidated update branch for Context and Intents |
@mistryvinay actually looks like I've got small git snafu after changing the base, will fix. |
42419cf
to
3a43bba
Compare
fixed and good to go @mistryvinay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-2.1' into 856-chart-otherconfig-improvement
@greyseer256 please check this one when you have a second, so we can merge into the consolidated Context & Intents branch for 2.1 |
fdbd1c5
into
fix-context-data-and-intents-consolidated-update-branch-2.1
resolves #856
Changes the definition of
otherConfig
in fdc3.chart from an unstandardized object to an array of Context objects. This allows the type of each additional piece of config to be checked and either used or ignored by a charting application, based on its type.@rbruckheimer