-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply CC-BY-SA 4.0 license to the FINOS InnerSource Special Interest Group InnerSource
repository
#39
Conversation
InnerSource
repository
InnerSource
repositoryInnerSource
repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for getting this all worked out, very exciting!
LICENSE.spdx
Outdated
"PackageOriginator": "FINOS, The Fintech Open Source Foundation", | ||
"PackageHomePage": "https://github.com/finos/innersource", | ||
"PackageLicenseDeclared": ["CC-BY-SA-4.0", "Apache-2.0"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a new line here 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved through cd00cc4 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer required due to changes in #39 (comment)
LICENSE.spdx
Outdated
PackageHomePage: https://github.com/finos/{project slug} | ||
PackageLicenseDeclared: Apache-2.0 | ||
{ | ||
"SPDXVersion": "SPDX-2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the latest format is 2.2.. also, should the format be in JSON? I can't seem to find examples for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following commits should resolve the feedback in this comment.
- Updated
"SPDXVersion": "SPDX-2.2",
via 110ea80 - Update format of
LICENCE.spdx
to removejson
through 3772e47
Updated SPDX Format
SPDXVersion: SPDX-2.2
DataLicense: CC0-1.0
Creator: FINOS, The Fintech Open Source Foundation
PackageName: InnerSource Special Interest Group
PackageOriginator: FINOS, The Fintech Open Source Foundation
PackageHomePage: https://github.com/finos/innersource
PackageLicenseDeclared: CC-BY-SA-4.0 AND Apache-2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You could remove "distributed under" from the Apache language in the README, but it's not a big deal either way.
Hi @copiesofcopies - Thank you for your feedback. I have revolved your comment here 8d832af
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The non-JSON format looks good and I do recall reading the AND for two license.
Feel free to merge @amaltson! 👏🏻 💯 💯 💯 |
Probably should use the standard REUSE formatting for the licenses: https://reuse.software/tutorial/ |
Hi @vmbrasseur - Thanks for the suggestion. It would be great if you could raise an issue so we can discuss with @amaltson and @copiesofcopies against the wider FINOS governance and boilerplates 👍🏻 James. |
And worth adding an issue to aim to add the Reuse helper tool (https://reuse.software/tutorial/#step-3) as a GitHub action (if possible) to automatically check compliance on commits. |
Hi @godds - Feel free to add this feature to the issue suggested to @vmbrasseur above 👍🏻 https://github.com/finos/InnerSource/issues/new?assignees=&labels=&template=Feature_request.md |
Description
This pull request adds and updates the following files to apply the
CC-BY-SA 4.0
license to the FINOS InnerSource Special Interest GroupInnerSource
repository.Note : The initial PR review should me made by @copiesofcopies before merging into the
InnerSource
repo.LICENSE-CC-BY-SA-4.0
withLICENSE-CC-BY-SA-4.0
license text.LICENCE.spdx
to reflect licenses that have been applied to theInnerSource
repository.LICENSE-CC-BY-SA-4.0
andAPACHE 2.0
licenses.Daniela Zheleva
(@daniela-g-zheleva-db) fromREADME.md
as InnerSource SIG co-lead.LICENCE.spdx Update
The following is the updated
LICENCE.spdx
content.Note: The format of
LICENCE.spdx
was changed to nonjson
as part of #39 (comment)