SDA-3626 Electron 17.3.0 upgrade (#1371) #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SDA-3626 Electron 17.3.0 upgrade * SDA-3626 Moving DesktopCapturer call to main process
sbenmoussati
force-pushed
the
feature/SDA-3626-main
branch
from
e781d5e
to
3588871
Compare
KiranNiranjan
approved these changes
Apr 5, 2022
| @@ -17,7 +17,6 @@ | |||
| "browserify-preload-component": "browserify -o lib/src/renderer/_preload-component.js -x electron --insert-global-vars=__filename,__dirname lib/src/renderer/preload-component.js", | |||
| "compile": "run-s lint compile:*", | |||
| "compile:project": "gulp build", | |||
| "compile:spec": "tsc -p tsconfig.spec.json", | |||
There was a problem hiding this comment.
We need this for unit tests right?
There was a problem hiding this comment.
As per my understanding, this tsconfig file is specific to Spectron which is not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDA-3626 Electron 17.3.0 upgrade
SDA-3626 Moving DesktopCapturer call to main process