Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-3677 Screen sharing issue on VDIs #1412

Merged
merged 1 commit into from
May 6, 2022
Merged

SDA-3677 Screen sharing issue on VDIs #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/app/window-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,20 +1469,18 @@ export class WindowHandler {
// SDA-3646 hack for macOS: whenever we try to close the penultimate window (here screensharing screen picker), Electron activates the last Electron window
// This behaviour was observed while trying to upgrade from Electron 14 to Electron 17
// Here the hack to solve that issue is to create a new invisible BrowserWindow.
if (isMac) {
this.screenPickerPlaceholderWindow = new BrowserWindow({
width: 0,
height: 0,
transparent: true,
frame: false,
x: 0,
y: 0,
resizable: false,
movable: false,
fullscreenable: false,
});
this.screenPickerPlaceholderWindow.show();
}
this.screenPickerPlaceholderWindow = new BrowserWindow({
width: 0,
height: 0,
transparent: true,
frame: false,
x: 0,
y: 0,
resizable: false,
movable: false,
fullscreenable: false,
});
this.screenPickerPlaceholderWindow.show();
}

window.send('start-share' + id, source);
Expand Down