Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static code analysis setup #1648

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

sbenmoussati
Copy link
Contributor

Description

Static code analysis setup

Copy link
Contributor

@NguyenTranHoangSym NguyenTranHoangSym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/finos/SymphonyElectron/actions/runs/3754227925/jobs/6378264857
This looks like lacking of something. From the point of failure.
Can you add a few more?

src/renderer/components/message-banner.tsx
104┆ onlineStateIntervalId = setInterval(async () => {

src/common/logger.ts
277┆ const filePath = path.join(this.logPath, file);

src/common/i18n.ts
112┆ ${locale}.json

src/app/app-cache-handler.ts
29┆ const filePath = path.join(userDataPath, file);

spec/config.spec.ts
16┆ return path.join(fs.mkdtempSync(path.join(tmpDir, 'config-')), fileName);

dockerfile.security.missing-user.missing-user
38┆ CMD ["chmod +x scripts/build-linux.sh"]

@sbenmoussati
Copy link
Contributor Author

https://github.com/finos/SymphonyElectron/actions/runs/3754227925/jobs/6378264857 This looks like lacking of something. From the point of failure. Can you add a few more?

src/renderer/components/message-banner.tsx 104┆ onlineStateIntervalId = setInterval(async () => {

src/common/logger.ts 277┆ const filePath = path.join(this.logPath, file);

src/common/i18n.ts 112┆ ${locale}.json

src/app/app-cache-handler.ts 29┆ const filePath = path.join(userDataPath, file);

spec/config.spec.ts 16┆ return path.join(fs.mkdtempSync(path.join(tmpDir, 'config-')), fileName);

dockerfile.security.missing-user.missing-user 38┆ CMD ["chmod +x scripts/build-linux.sh"]

All these points are already addressed in this PR, reason why we don't have any build failure @NguyenTranHoangSym .

@sbenmoussati sbenmoussati merged commit b4d5f6d into finos:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants