Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDA-4219 (Change logic to use minimize/restore instead of hide/show) #1908

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

KiranNiranjan
Copy link
Member

@KiranNiranjan KiranNiranjan commented Jul 25, 2023

Description

  • Change logic to use minimize/restore for Windows and hide/show for macOS

Demo

Popout
popout

Fullscreen
full_screen

Minimize / Restore single window
Animation

Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
@KiranNiranjan KiranNiranjan merged commit 13289e6 into finos:main Jul 26, 2023
@KiranNiranjan KiranNiranjan deleted the SDA-4219 branch July 26, 2023 06:24
NguyenTranHoangSym pushed a commit to NguyenTranHoangSym/SymphonyElectron that referenced this pull request Sep 5, 2023
…inos#1908)

* SDA-4219 - Change from hide to minimize

Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>

* SDA-4219 - Remove unused function

Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>

* SDA-4241 - Revert fix for macOS

Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>

---------

Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants