RTC-14731 - update "showScreenSharingIndicator" method #2062
Conversation
| @@ -512,12 +512,9 @@ export class SSFApi { | |||
| } | |||
|
|
|||
| /** | |||
| * Shows a banner that informs user that the screen is being shared. | |||
| * Shows a banner that informs the user that the screen is being shared. | |||
There was a problem hiding this comment.
This method is now pretty much identical to openScreenSharingIndicator. The only difference is if requestId is tracked in SymphonyElectron or if it's passed. Should we remove openScreenSharingIndicator?
I see a handleMessage property in app-bridge.ts, and it says it's only for 1.5. I think that's what's being used right now by screen sharing, but is anyone else using this method? If not, then we should remove that entire piece of code.
There was a problem hiding this comment.
Only RTC and client 1.5 was using the app-bridge.ts, now I think we will need remove the complete code
axeleriksson147
changed the title
| const destroy = () => { | ||
| throttledCloseScreenShareIndicator(stream.id); | ||
| stream.removeEventListener('inactive', destroy); | ||
| }; | ||
|
|
||
| stream.addEventListener('inactive', destroy); |
There was a problem hiding this comment.
https://www.electronjs.org/docs/latest/api/context-bridge#parameter--error--return-type-support - This doesn't work due to these reasons. SFE-RTC will have to be responsible for closing the screen sharing indicator (which is probably better, SymphonyElectron shouldn't do too much).
showScreenSharingIndicatoris a method used by Symphony Meetings. However, when we switched from Client 1.5 to 2.0, the window object for SymphonyElectron changed name and we haven't used this method in about 3 years. However, I am investigating https://perzoinc.atlassian.net/browse/RTC-14615 about screen sharing issues and one possible explanation is that our current way of sharing screen by posting messages viawindow.postMessagedisappears or don't get picked up. Therefore we should look into using the exposed SymphonyElectron methods via the window object. It could be more reliable.