Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #669-ui/docs: clone component is undefined when running as a server #735

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

RajvirS99
Copy link
Contributor

closes #669

Instead of getting the origin from the vite environment variables, the component will now get the origin from browsers
JavaScript location API and It won't show undefined in the server

Copy link

linux-foundation-easycla bot commented Oct 2, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the fix label Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d255708
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66fd86b811b1600008429294

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (3b6cb6b) to head (d255708).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome merged commit c641773 into finos:main Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui/docs: clone component is undefined when running as a server
2 participants