Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi cluster query to lineage #3093

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

AFine-gs
Copy link
Contributor

What type of PR is this?

What does this PR do / why is it needed ?

@AFine-gs AFine-gs requested a review from a team as a code owner September 16, 2024 14:35
Copy link

Test Results

  1 033 files  ±0    1 033 suites  ±0   1h 25m 56s ⏱️ -17s
12 265 tests ±0  12 175 ✔️ ±0  90 💤 ±0  0 ±0 
17 956 runs  ±0  17 866 ✔️ ±0  90 💤 ±0  0 ±0 

Results for commit e9cd185. ± Comparison against base commit d360a4f.

@AFine-gs AFine-gs enabled auto-merge (squash) September 16, 2024 18:09
assertEquals(['Lambda', 'tb_dbIncdefaultpersonTable', 'tb_dbIncdefaultfirmTable', 'tb_database2defaultfirmTable', 'db_dbInc', 'db_database2'],$lineage.databaseLineage.nodes.data.id);

true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this



// meta::pure::executionPlan::executionPlan($fn,meta::relational::tests::tds::tdsJoin::testJoinTDSMappingTwoDatabaseWithColumnsMappedViaJoinsAndDynaFunction,meta::relational::tests::tds::tdsJoin::twoDBRunTime() ,relationalExtensions())->meta::pure::executionPlan::toString::planToString(relationalExtensions())->println();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep this?

Copy link
Contributor

@aziemchawdhary-gs aziemchawdhary-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray code to be fixed in subsequent commit

@AFine-gs AFine-gs merged commit d6ccbce into finos:master Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants